8000 [DependencyInjection] Add section about Service Closures by HypeMC · Pull Request #15731 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Add section about Service Closures #15731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

[DependencyInjection] Add section about Service Closures #15731

merged 1 commit into from
Mar 9, 2023

Conversation

HypeMC
Copy link
Member
@HypeMC HypeMC commented Aug 19, 2021 •
edited
Loading

Documents service closures added in symfony/symfony#21770 and symfony/symfony#41176, and the service_closure() PHP-DSL function added in symfony/symfony#42625 .

@HypeMC HypeMC mentioned this pull request Aug 19, 2021
Merged
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch 4 times, most recently from 562d799 to 1dea8a0 Compare August 20, 2021 01:09
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Aug 20, 2021
@nicolas-grekas
feature #42625 [DependencyInjection] Add service_closure() to the PHP…
a42062d 
…-DSL (HypeMC)

This PR was merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Add service_closure() to the PHP-DSL

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#15730 and symfony/symfony-docs#15731

Adds a `service_closure()` function to the PHP-DSL.

Commits
-------

f333fa0 [DI] Add service_closure() to the PHP-DSL
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull request Aug 20, 2021
@nicolas-grekas
feature #42625 [DependencyInjection] Add service_closure() to the PHP…
2737fcb 
…-DSL (HypeMC)

This PR was merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Add service_closure() to the PHP-DSL

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#15730 and symfony/symfony-docs#15731

Adds a `service_closure()` function to the PHP-DSL.

Commits
-------

f333fa0e05 [DI] Add service_closure() to the PHP-DSL
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch from 1dea8a0 to 822bcec Compare August 20, 2021 16:08
@javiereguiluz javiereguiluz added this to the 5.4 milestone Jun 10, 2022
@HypeMC HypeMC mentioned this pull request Oct 1, 2022
Closed
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch from 822bcec to 1e40081 Compare October 1, 2022 14:25
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
service_container/service_closures.rst Outdated
Comment on lines 96 to 97
Using Service Closures in Compiler Passes
-----------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using Service Closures in Compiler Passes
-----------------------------------------
Using Service Closures in Compiler Pass
---------------------------------------

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even use Service Closure (singular) in the headline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "Using a Service Closures in a Compiler Pass"?

OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch 2 times, most recently from 005216a to 8ab82c2 Compare October 1, 2022 18:52
@OskarStark OskarStark changed the title [DependencyInjection] Document PHP-DSL service_closure() function [DependencyInjection] Document PHP-DSL service_closure() function Oct 2, 2022
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch 4 times, most recently from ab6d0d0 to b69cdaa Compare March 2, 2023 08:47
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch from b69cdaa to 1958c06 Compare March 2, 2023 11:58
@HypeMC HypeMC changed the title [DependencyInjection] Document PHP-DSL service_closure() function [DependencyInjection] Add section about Service Closures Mar 2, 2023
@OskarStark OskarStark requested a review from javiereguiluz March 2, 2023 12:52
@OskarStark OskarStark requested a review from HeahDude March 2, 2023 12:52
jdreesen
jdreesen reviewed Mar 8, 2023
View reviewed changes
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch from f391a2c to 28f9b55 Compare March 9, 2023 04:33
@HypeMC HypeMC force-pushed the service-closure-php-dsl branch from 28f9b55 to f2b2fdb Compare March 9, 2023 04:35
@OskarStark
Copy link
Contributor

Thank you @HypeMC.

@OskarStark OskarStark merged commit defdea4 into symfony:5.4 Mar 9, 2023
@HypeMC HypeMC deleted the service-closure-php-dsl branch March 9, 2023 08:25
HeahDude
HeahDude reviewed Mar 11, 2023
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this PR, I've left a small comment, sorry for the delay.

OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Mar 11, 2023
@OskarStark
Be consistent in code examples
cbb3863 
Follows symfony#15731 (comment)
@OskarStark OskarStark mentioned this pull request Mar 11, 2023
Merged
OskarStark added a commit that referenced this pull request May 11, 2023
@OskarStark
minor #18050 Be consistent in code examples (OskarStark)
7597ea3
8000 
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

Be consistent in code examples

Follows #15731 (comment)

cc `@HeahDude`

Commits
-------

2426ce4 Be consistent in code examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen left review comments

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude left review comments

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@HypeMC @OskarStark @jdreesen @HeahDude @javiereguiluz @carsonbot
0