8000 [Twig] Global variable in TwigConfig should be passed by service function by tugmaks · Pull Request #15495 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Twig] Global variable in TwigConfig should be passed by service function #15495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[Twig] Global variable in TwigConfig should be passed by service function #15495

merged 1 commit into from
Jul 12, 2021

Conversation

tugmaks
Copy link
Contributor
@tugmaks tugmaks commented Jul 7, 2021

No description provided.

@carsonbot carsonbot changed the title Global variable in TwigConfig should be passed by service function [Twig] Global variable in TwigConfig should be passed by service function Jul 12, 2021
@javiereguiluz javiereguiluz modified the milestones: 5.2, 5.3 Jul 12, 2021
@javiereguiluz javiereguiluz merged commit 318466c into symfony:5.3 Jul 12, 2021
@javiereguiluz
Copy link
Member

Maxim, thanks for fixing this error! While merging I also fixed the XML syntax following the format used in this test: https://github.com/symfony/symfony/blob/e34cd7dd2c6d0b30d24cad443b8f964daa841d71/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/Fixtures/xml/full.xml

@tugmaks tugmaks deleted the twigconfig-gloabal-var branch July 12, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Twig
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tugmaks @javiereguiluz @carsonbot
0