[Logger] [Monolog] Add ConfigBuilders for Monolog #15278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Apr 22, 2021
| ->fromEmail('error@example.com') | ||
| ->toEmail(['error@example.com']) | ||
| // or a list of recipients | ||
| // ->toEmail(['dev1@example.com', 'dev2@example.com', ...]) |
There was a problem hiding this comment.
Im not sure we need to show that a "list of recipients" is possible since toEmail() requires an array.
Nyholm
commented
Apr 22, 2021
| ->fromEmail('error@example.com') | ||
| ->toEmail(['error@example.com']) | ||
| // or a list of recipients | ||
| // ->toEmail(['dev1@example.com', 'dev2@example.com', ...]) |
|
Thanks Tobias. While merging I left the examples that you wondered about. You are right that they are not strictly needed, but they probably were added to avoid confusion of some readers, so let's keep it for now. Thanks! |
|
Thank you for merging and for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only two more PRs after this =)