8000 Fixed syntax errors on 4.4 by Nyholm · Pull Request #15266 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
8000

Fixed syntax errors on 4.4 #15266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fixed syntax errors on 4.4 #15266

merged 1 commit into from
Apr 21, 2021

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Apr 20, 2021 •
edited
Loading

I ran the new parser on 4.4. There are about 130 more syntax errors that I decided not to fix. Some are false positives (ie a code example where we only have a PHP array). Others show some limitations of the parser. Ie, we cannot automatically detect a code block with no language, we currently assume it is PHP but that is not always correct.

This is the last fixes I'll do for 4.4.

@Nyholm Nyholm requested a review from xabbuh as a code owner April 20, 2021 21:21
@Nyholm Nyholm changed the base branch from 5.x to 4.4 April 20, 2021 21:21
Nyholm
Nyholm commented Apr 20, 2021
View reviewed changes
wouterj
wouterj approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many good fixes! 😍 (actually: 100% good fixes)

@Nyholm
Copy link
Member Author
Nyholm commented Apr 21, 2021

Thank you for the review. I've updated the non-php code blocks.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 21, 2021
@javiereguiluz
Copy link
Member

Tobias, you're on a roll! What an amazing stream of cool PRs you are contributing lately 😍 Thank you 🙇‍♂️

@javiereguiluz javiereguiluz merged commit 5398a93 into symfony:4.4 Apr 21, 2021
@Nyholm
Copy link 8000
Member Author
Nyholm commented Apr 21, 2021

Im happy you are appreciating the work.

Thank you for merging

@Nyholm Nyholm deleted the syntax-errors-2 branch April 21, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @javiereguiluz @wouterj @carsonbot
0