8000 [Profiler] Remove unused import by sebpacz · Pull Request #15020 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Profiler] Remove unused import #15020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Profiler] Remove unused import #15020

wants to merge 1 commit into from

Conversation

sebpacz
Copy link
Contributor
@sebpacz sebpacz commented Feb 23, 2021 •
edited
Loading

I removed the DataCollector class import because it has been replaced with the AbstractDataCollector class.

@sebpacz
< 8000 div class="pr-1 flex-auto min-width-0" > Update data_collector.rst
2c3e6f7 
I removed the DataCollector class import because it has been replaced with the AbstractDataCollector class.
@sebpacz sebpacz changed the title Update data_collector.rst [Profiler] Remove unused import Feb 28, 2021
@wouterj
Copy link
Member
wouterj commented Apr 7, 2021

Hi Sebastian. Sorry for the long wait, this seems completely valid. Thanks for submitting the fix!

wouterj added a commit that referenced this pull request Apr 7, 2021
@wouterj
bug #15020 [Profiler] Remove unused import (sebpacz)
1a3d0d3 
This PR was merged into the 5.2 branch.

Discussion
----------

[Profiler] Remove unused import

I removed the DataCollector class import because it has been replaced with the AbstractDataCollector class.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `5.x` for features of unreleased versions).

-->

Commits
-------

1834da9 Update data_collector.rst
@wouterj
Copy link
Member
wouterj commented Apr 7, 2021

Hmm, I'm not sure why this PR isn't marked as merged. It really is merged, see commit 1a3d0d3 .

@wouterj wouterj closed this Apr 7, 2021
@sebpacz sebpacz deleted the patch-3 branch April 11, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebpacz @wouterj @maxhelias @carsonbot
0