8000 Update the Nginx example by sebpacz · Pull Request #14698 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update the Nginx example #14698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Update the Nginx example #14698

merged 1 commit into from
Jan 22, 2021

Conversation

sebpacz
Copy link
Contributor
@sebpacz sebpacz commented Dec 13, 2020

When I was looking through the Nginx configuration recipe for Symfony 4.x I discovered an important comment that isn’t included in the example in the Nginx section. I think this tip may be useful for those who create their environment using docker containers. In this PR I added the missing comment, which is taken from the recipe on this page: https://www.nginx.com/resources/wiki/start/topics/recipes/symfony/#secure-symfony-4-x.

@sebpacz
Update the Nginx example
f5ebf42 
When I was looking through the Nginx configuration recipe for Symfony 4.x I discovered an important comment that isn’t included in the example in the Nginx section. I think this tip may be useful for those who create their environment using docker containers. In this PR I added the missing comment, which is taken from the recipe on this page: https://www.nginx.com/resources/wiki/start/topics/recipes/symfony/#secure-symfony-4-x.
@carsonbot carsonbot added this to the 4.4 milestone Dec 13, 2020
@ghost
Copy link
ghost commented Dec 15, 2020

This caveat might get lost in the large code example. My suggestion is to use a tip block under the code block that highlights this caveat:

.. tip::

    When PHP-FPM is hosted on a different machine from nginx $realpath_root
    may not resolve as expected! In this case try using $document_root instead.

@javiereguiluz
Copy link
Member

Sebastian, thanks for updating this config according to the official nginx wiki example.

@javiereguiluz javiereguiluz merged commit 3732796 into symfony:4.4 Jan 22, 2021
@sebpacz sebpacz deleted the patch-4 branch January 22, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@sebpacz @javiereguiluz @carsonbot
0