8000 [DependencyInjection] Minor modification about the .meta file contents by l-vo · Pull Request #14661 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Minor modification about the .meta file contents #14661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

[DependencyInjection] Minor modification about the .meta file contents #14661

merged 1 commit into from
Dec 7, 2020

Conversation

l-vo
Copy link
Contributor
@l-vo l-vo commented Dec 5, 2020

The explanation about the .meta file contents is not totally true. Only ComposerResource stores timestamps (for installed.json files). For project source and configuration files involved in the generation of a file in the cache, the filemtime is directly used to retrieve the resource timestamp and to compare it with the filemtime of the generated file.

Source: https://github.com/symfony/symfony/blob/21ef411cc96459d0d87ac3e1d565aca4bba1cb21/src/Symfony/Component/Config/Resource/FileResource.php#L65

@l-vo
Minor modification about the .meta file contents
f2a3cf5 
The explanation about the `.meta` file contents is not totally true. Only `ComposerResource` stores timestamps (for `installed.json` files). For project source and configuration files involved in the generation of a file in the cache, the `filemtime` is directly used to retrieve the resource timestamp and to compare it with the `filemtime` of the generated file.

Source: https://github.com/symfony/symfony/blob/21ef411cc96459d0d87ac3e1d565aca4bba1cb21/src/Symfony/Component/Config/Resource/FileResource.php#L65
@carsonbot carsonbot added this to the 4.4 milestone Dec 5, 2020
@carsonbot carsonbot changed the title Minor modification about the .meta file contents [DependencyInjection] Minor modification about the .meta file contents Dec 7, 2020
@OskarStark
Copy link
Contributor

Thank you Laurent.

@OskarStark OskarStark merged commit e8324ad into symfony:4.4 Dec 7, 2020
@l-vo l-vo deleted the patch-6 branch December 7, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark 582F OskarStark approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@l-vo @OskarStark @carsonbot
0