10BC0 [Messenger] Fix a typo on Messenger handler results example by alepdev · Pull Request #14535 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Fix a typo on Messenger handler results example #14535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

[Messenger] Fix a typo on Messenger handler results example #14535

merged 1 commit into from
Nov 12, 2020

Conversation

@alepdev
Copy link
Contributor
@alepdev alepdev commented Nov 11, 2020

This fixes typo on the Messenger handler results sample snippet by renaming Result object since the definition in the import and the name used in the return type of the function did not match.

I fixed with ListItemsResult instead of ListItemsQueryResult but tell me which one is better.

@carsonbot carsonbot added this to the 4.2 milestone Nov 11, 2020
@carsonbot carsonbot changed the title Fix a typo on Messenger handler results example [Messenger] Fix a typo on Messenger handler results example Nov 12, 2020
@carsonbot carsonbot changed the title Fix a typo on Messenger handler results example [Messenger] Fix a typo on Messenger handler results example Nov 12, 2020
@javiereguiluz javiereguiluz modified the milestones: 4.2, 4.4 Nov 12, 2020
@javiereguiluz javiereguiluz changed the base branch from 4.2 to 4.4 November 12, 2020 09:26
@javiereguiluz javiereguiluz merged commit 657e662 into symfony:4.4 Nov 12, 2020
@javiereguiluz
Copy link
Member
javiereguiluz commented Nov 12, 2020 •
edited
Loading

Alessio, thanks for fixing this bug. We did a couple of changes while merging:

  • We merged in 4.4 (and 5.1 and 5.x) because 4.2 is no longer maintained. We only merge on maintained branches. You can find those branches here: https://symfony.com/releases
  • As you mentioned, the fix can be reversed to use the imported ListItemsQueryResult class. We did that because the class name looked more consistent with the existing ListItemsQuery.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Messenger Status: Reviewed

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@alepdev @javiereguiluz @carsonbot
0