10000 add html extension to snake_case recommendation examples by ybenhssaien · Pull Request #14530 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

add html extension to snake_case recommendation examples #14530

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2020
Merged

add html extension to snake_case recommendation examples #14530

merged 2 commits into from
Nov 12, 2020

Conversation

ybenhssaien
Copy link
Contributor
@ybenhssaien ybenhssaien commented Nov 11, 2020 •
edited
Loading

Some readers may inconsciently memorize the syntax file_name.twig and ignores the second recommendation (declaring two extension html.twig), it can happen if someone looks only for snak_case keyword without reading the whole page (at least the second recommentdation).

I suggest to add html extension on the first examples to make sure the second recommendation cannot escape reader's eyes.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Nov 12, 2020
javiereguiluz
javiereguiluz approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better! Thanks Youssef!

Note to mergers: merge in 4.4

@ybenhssaien @OskarStark
add html extension to snake_case recommendation examples
b3ef599 
Some readers may inconsciently memorize the syntax `file_name.twig` and ignores the second `recommendation` (declaring two extension `html.twig`), it can happen if someone looks only for `snak_case` keyword without reading whole page.

I suggest to add `html` extension on the first examples to make sure recommendations cannot escape reader.
@OskarStark OskarStark changed the base branch from 5.1 to 4.4 November 12, 2020 09:02
@OskarStark
Copy link
Contributor

Thank you Youssef.

@OskarStark OskarStark merged commit c732edf into symfony:4.4 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Templating
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ybenhssaien @OskarStark @javiereguiluz @carsonbot
0