8000 Adjust wording at Generating URLs by reneroboter · Pull Request #14444 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Adjust wording at Generating URLs #14444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Adjust wording at Generating URLs #14444

merged 1 commit into from
Oct 19, 2020

Conversation

reneroboter
Copy link
Contributor

At "Generating URLs in JavaScript" the Twig escape filter is called a escape function. However in context of Twig this is a filter and I guess it should use the right wording also in the Symfony docs.

noniagriconomie
noniagriconomie 8000 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor
@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 you can target 4.4 i think

@xabbuh xabbuh added this to the 4.4 milestone Oct 19, 2020
@reneroboter @wouterj
Adjust wording at Generating URLs
6662660 
At "Generating URLs in JavaScript" the Twig escape filter is called a escape function. However in context of Twig this is a filter and I guess it should use the right wording also in the Symfony docs.
@wouterj wouterj changed the base branch from 5.1 to 4.4 October 19, 2020 22:03
@wouterj wouterj requested a review from HeahDude as a code owner October 19, 2020 22:03
@wouterj
Copy link
Member
wouterj commented Oct 19, 2020 •
edited
Loading

Thank you René! This is a perfect fix indeed. I've merged this into 4.4 (the oldest branch we still maintain) and will make sure it gets merged in all newer versions from there.

@wouterj wouterj merged commit bf01eff into symfony:4.4 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@noniagriconomie noniagriconomie noniagriconomie approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@reneroboter @wouterj @xabbuh @noniagriconomie @carsonbot
0