8000 Made all messenger transport look the same by Nyholm · Pull Request #14404 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Made all messenger transport look the same #14404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2020
Merged

Made all messenger transport look the same #14404

merged 1 commit into from
Oct 17, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Oct 13, 2020 •
edited
Loading

This PR is fixing the Transport Configuration in the Messenger component. https://symfony.com/doc/5.2/messenger.html#transport-configuration

I added the following order:

Foo Transport
~~~~~~~~~~

One line introduction of Foo. Install it by running:

.. code-block:: terminal

    $ composer require symfony/foo-messenger

The Foo transport DSN may looks like this:

.. code-block:: env

    # .env
    MESSENGER_TRANSPORT_DSN=foo://default

[Any other info about the transport]

The transport has a number of options:

[Table with options]

[Other notes and option related stuff.]

Nyholm
Nyholm commented Oct 13, 2020
View reviewed changes
messenger.rst
# .env
MESSENGER_TRANSPORT_DSN=amqp://localhost/%2f/messages?auto_setup=false

.. configuration-block::
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently only Doctrine and Beanstalkd had this section. It applies to all transports to I moved it up.

wouterj
wouterj reviewed Oct 13, 2020
View reviewed changes
@Nyholm Nyholm mentioned this pull request Oct 13, 2020
Merged
@Nyholm
Copy link
Member Author
Nyholm commented Oct 13, 2020

Thank you for the review

fabpot added a commit to symfony/symfony that referenced this pull request Oct 14, 2020
@fabpot
minor #38555 [Messenger] Fixed typos in Amqp Connection (Nyholm)
4529e08 
This PR was submitted for the 5.x branch but it was merged into the 5.1 branch instead.

Discussion
----------

[Messenger] Fixed typos in Amqp Connection

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | n/a

Sorry for a small PR. When working with symfony/symfony-docs#14404, I found a typo, then another one.. When I found 4 of them I decided to make a PR.

Commits
-------

5dec141 [Messenger] Fixed typos in Connection
@Nyholm Nyholm mentioned this pull request Oct 14, 2020
Closed
@Nyholm Nyholm force-pushed the messenger-transport branch from f64a29c to 41ba42a Compare October 15, 2020 06:11
@javiereguiluz javiereguiluz added this to the 5.2 milestone Oct 17, 2020
@javiereguiluz
Copy link
Member

Merged! We love consistent docs, so this is a very nice change. Thanks Tobias!

@javiereguiluz javiereguiluz merged commit 0a5df46 into symfony:5.x Oct 17, 2020
@Nyholm
Copy link
Member Author
Nyholm commented Oct 17, 2020

Thank you for the review and merge.

@Nyholm Nyholm deleted the messenger-transport branch October 17, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @javiereguiluz @wouterj @carsonbot
0