8000 Fix missing namespace and other wrong wording from Security and Serializer context by TheGarious · Pull Request #14349 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix missing namespace and other wrong wording from Security and Serializer context #14349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix missing namespace and other wrong wording from Security and Serializer context #14349

merged 1 commit into from
Oct 22, 2020

Conversation

TheGarious
Copy link
Contributor

No description provided.

@javiereguiluz
Copy link
Member

Thanks for this contribution!

I like the idea of always showing the file path ... but the "namespace" is not always displayed. If an article is always showing the same example, we use // ... in the following examples to hide the "namespace" and the previous "use" (we only display the new "use").

Also, this kind of PRs are tricky because they can introduce several merge con 8000 flicts, so it's better to create them in the lowest maintained branch that needs these changes (e.g. 4.4.)

@TheGarious
Copy link
Contributor Author

No problem @javiereguiluz,

I see many page where namespace and filepath is always implemented and the other page not.
I was thinking is better to add all time.
I correct relicat Bundle present into security/named_encoders.rst.

I need to change the branch target ?

@xabbuh xabbuh added this to the 4.4 milestone Oct 8, 2020
@TheGarious
Copy link
Contributor Author

@javiereguiluz @xabbuh up

@javiereguiluz javiereguiluz changed the base branch from master to 4.4 October 22, 2020 15:39
@javiereguiluz javiereguiluz force-pushed the fix_wording/security_serializer branch from 38cd191 to 22345e0 Compare October 22, 2020 15:39
@javiereguiluz
Copy link
Member

Thanks Gary! Merged in 4.4 and up.

@javiereguiluz javiereguiluz merged commit a20f40a into symfony:4.4 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@TheGarious @javiereguiluz @maxhelias @xabbuh @carsonbot
0