8000 minor [#14292] UserProvider::supportsClass by CharlyPoppins · Pull Request #14293 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

minor [#14292] UserProvider::supportsClass #14293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

minor [#14292] UserProvider::supportsClass #14293

wants to merge 3 commits into from

Conversation

CharlyPoppins
Copy link
Contributor

@CharlyPoppins CharlyPoppins mentioned this pull request Sep 27, 2020
Closed
@CharlyPoppins
Copy link
Contributor Author

Build documentation failed do I need to change something ?

@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Sep 29, 2020
@javiereguiluz
Copy link
Member

Charly, thanks for this contribution. The build error is unrelated to your changes (it was a temporary issue in another article).

While we wait to see if this feature is merged in Maker bundle, we'll need to update something in this pull request:

|| is_subclass_of($class, <?= $user_short_name ?>::class; -> || is_subclass_of(User::class);

You used the code that Maker runs to generate the code, but in the Symfony Docs we should display instead the result of executing that code.

@CharlyPoppins
Copy link
Contributor Author

You used the code that Maker runs to generate the code, but in the Symfony Docs we should display instead the result of executing that code.

Silly me...

I tought <?= $user_short_name ?> was something generated with/by .rst files

@CharlyPoppins
Copy link
Contributor Author

Hum, squashing made unwanted changes... I don't know how to handle this.

I created a new PR : #14304

Which on of these both should be closed ?

@javiereguiluz
Copy link
Member

No worries. By the way, there's no need to squash changes because the tool we use to merge PRs does that automatically for us. Closed in favor of #14304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlyPoppins @javiereguiluz @carsonbot @elghailani
0