8000 Add missing `->end()` method call by jdreesen · Pull Request #14283 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add missing ->end() method call #14283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

Add missing ->end() method call #14283

merged 1 commit into from
Sep 25, 2020

Conversation

jdreesen
Copy link
Contributor

I think for the consistency it might be good to add an ->end() call here.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Sep 25, 2020
@javiereguiluz
Copy link
Member

Thank you Jacob.

@javiereguiluz javiereguiluz merged commit 8cea2ad into symfony:3.4 Sep 25, 2020
@jdreesen jdreesen deleted the patch-1 branch September 25, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Config Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jdreesen @javiereguiluz @carsonbot
0