8000 fix default value of choice_translation_domain for choice types by xabbuh · Pull Request #14220 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

fix default value of choice_translation_domain for choice types #14220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

fix default value of choice_translation_domain for choice types #14220

merged 1 commit into from
Sep 25, 2020

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Sep 11, 2020

@xabbuh xabbuh added the Form label Sep 11, 2020
@xabbuh xabbuh added this to the 3.4 milestone Sep 11, 2020
@xabbuh xabbuh requested a review from HeahDude as a code owner September 11, 2020 16:15
@xabbuh xabbuh changed the title fix default value for choice_translation_domain of the EntityType fix default value for choice_translation_domain of some form types Sep 11, 2020
@xabbuh xabbuh marked this pull request as draft September 11, 2020 16:23
@xabbuh xabbuh changed the title fix default value for choice_translation_domain of some form types fix default value of choice_translation_domain for choice types Sep 12, 2020
@xabbuh xabbuh changed the base branch from master to 3.4 September 12, 2020 12:32
@xabbuh xabbuh force-pushed the symfony-37521 branch 4 times, most recently from 67ae4d7 to a7b6bf9 Compare September 12, 2020 12:43
@xabbuh xabbuh mentioned this pull request Sep 12, 2020
Merged
@xabbuh xabbuh force-pushed the symfony-37521 branch 2 times, most recently from c8b7b73 to 9da0d40 Compare September 12, 2020 12:49
@xabbuh xabbuh marked this pull request as ready for review September 12, 2020 12:50
@javiereguiluz
Copy link
Member

Thank you Christian.

@javiereguiluz javiereguiluz merged commit 38503b1 into symfony:3.4 Sep 25, 2020
@xabbuh xabbuh deleted the symfony-37521 branch September 30, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @javiereguiluz @carsonbot
0