[Testing] Updated the contents about getting the container in tests #14071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Oct 22, 2020
2b9dfeb to
436e2fc
Compare
|
Thank you Javier. I think this is much clearer indeed :) |
| }; | ||
| public function testSomething() | ||
| { | ||
| $client = self::createClient(); |
There was a problem hiding this comment.
createClient doesn't exist when a test class inherit from KernelTestCase. Is there a workaround?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that using the container in tests is an edge-case ... but still, I think that the current docs are confusing and convoluted. This PR proposes to simplify the explanation of the different container types.