8000 Update symfony_server.rst - proxy env lowercase by damianz5 · Pull Request #13578 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update symfony_server.rst - proxy env lowercase #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Update symfony_server.rst - proxy env lowercase #13578

merged 1 commit into from
Apr 22, 2020

Conversation

damianz5
Copy link
Contributor

described in issue: #13577

@damianz5 damianz5 mentioned this pull request Apr 22, 2020
Closed
@damianz5 damianz5 requested a review from xabbuh as a code owner April 22, 2020 10:53
@damianz5 damianz5 changed the base branch from 4.2 to 3.4 April 22, 2020 10:54
@damianz5
Copy link
Contributor Author

rebased on 3.4 branch

@javiereguiluz javiereguiluz added this to the 3.4 milestone Apr 22, 2020
@javiereguiluz javiereguiluz merged commit 2a85848 into symfony:3.4 Apr 22, 2020
@javiereguiluz
Copy link
Member

@damianz5 thanks a lot for this contribution and for the great explanation in #13577. I didn't know about this ... and I guess many others don't know too ... so I added a minor note while merging to explain that this is a special env var and it must be in lowercase only. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@damianz5 @javiereguiluz @carsonbot
0