8000 [Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3 by alexandre-castelain · Pull Request #13550 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3 #13550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

[Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3 #13550

merged 1 commit into from
Jun 8, 2020

Conversation

alexandre-castelain
Copy link
Contributor

I noticed that in the BrowserKit documentation, there was multiple references to the old Symfony\Component\BrowserKit\Client class instead of the Symfony\Component\BrowserKit\AbstractBrowser one.

See symfony/symfony#30541

There was a previous merge request for SF5 here (#12717), but I don't know if it was possible for me to use it since I'm quite new with Github best practice about contribution.

Don't hesitate to tell me if I'm wrong!

@alexandre-castelain alexandre-castelain force-pushed the update-browserkit-client-to-browser branch from 2c0402b to a3ff4e0 Compare April 14, 2020 15:35
@alexandre-castelain alexandre-castelain changed the title The Client class has been replaced by the AbstractBrowser since SF 4.3 [Browserkit] The Client class has been replaced by the AbstractBrowser since SF 4.3 Apr 14, 2020
@javiereguiluz
Copy link
Member

@Calex92 thanks and congrats on your first Symfony Docs contribution! (sorry it took us so long to merge)

@javiereguiluz javiereguiluz merged commit d56e303 into symfony:4.4 Jun 8, 2020
@javiereguiluz javiereguiluz added this to the 4.4 milestone Jun 8, 2020
@javiereguiluz javiereguiluz mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BrowserKit Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-castelain @javiereguiluz @carsonbot
0