8000 Add details for pluralization on extra fields message by jpjoao · Pull Request #13542 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add details for pluralization on extra fields message #13542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2020
Merged

Add details for pluralization on extra fields message #13542

merged 1 commit into from
Apr 18, 2020

Conversation

jpjoao
Copy link
Contributor
@jpjoao jpjoao commented Apr 13, 2020
  • Add ref anchor for Pluralization;
  • Add link for Pluralization on extra fields message;

Fixes #13411

@jpjoao jpjoao requested review from HeahDude and xabbuh as code owners April 13, 2020 13:57
@HeahDude HeahDude added this to the 5.1 milestone Apr 13, 2020
@HeahDude HeahDude added the Form label Apr 13, 2020
HeahDude
HeahDude reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, we just miss a versionadded directive. Thank you!

@jpjoao jpjoao requested a review from HeahDude April 18, 2020 12:45
HeahDude
HeahDude approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (one minor comment)

@HeahDude HeahDude force-pushed the 13411-plural-extra-data branch from 3eae3a1 to ef275a3 Compare April 18, 2020 13:54
@HeahDude
Copy link
Contributor

Thank you @jpjoao.

@HeahDude HeahDude closed this in 3a49064 Apr 18, 2020
@HeahDude HeahDude merged commit 3a49064 into symfony:master Apr 18, 2020
@jpjoao jpjoao deleted the 13411-plural-extra-data branch April 18, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Form] Allowing plural message on extra data validation failure
3 participants
@jpjoao @HeahDude @carsonbot
0