-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Adds block about PHP-FPM behaviour #13468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds block about PHP-FPM behaviour #13468
Conversation
Related to the issue https://github.com/symfony/cli/issues/178 I added some documentation on the behaviour of the PHP-FPM in the webserver. Even though the behaviour is currently "expected" it is not obvious for the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, but I am not sure everyone will get what the tip is trying to warn about from the current wording. Maybe we should add something like, "This means when an index.html file is present in ``public``, it will be displayed instead of your Symfony application."
46e7e74
to
9b60a72
Compare
…precedence over the index.php
9b60a72
to
c7419b2
Compare
@dbrumann I have improved the message of the tip to make the behaviour clearer |
setup/symfony_server.rst
Outdated
---------------- | ||
|
||
When the server starts it will check the ``public`` folder for an ``index.php`` | ||
file. If this file is found the server will automatically start with PHP-FPM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabpot can you please check the first sentence? From your comment in the referenced issue, I get the feeling that more front-controller files are checked than just public/index.php
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it checks for "common" patterns like web/app.php
, web/app_dev.php
or public/index.php
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the text to mention those common patterns
setup/symfony_server.rst
Outdated
---------------- | ||
|
||
When the server starts it will check the ``public`` folder for an ``index.php`` | ||
file. If this file is found the server will automatically start with PHP-FPM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it checks for "common" patterns like web/app.php
, web/app_dev.php
or public/index.php
.
Related to the issue https://github.com/symfony/cli/issues/178 I added some documentation on the behaviour of the PHP-FPM in the webserver.
Even though the behaviour is currently "expected" it is not obvious for the user.