10000 Adds block about PHP-FPM behaviour by Eydamos · Pull Request #13468 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Adds block about PHP-FPM behaviour #13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

Eydamos
Copy link
Contributor
@Eydamos Eydamos commented Apr 1, 2020

Related to the issue https://github.com/symfony/cli/issues/178 I added some documentation on the behaviour of the PHP-FPM in the webserver.
Even though the behaviour is currently "expected" it is not obvious for the user.

Related to the issue https://github.com/symfony/cli/issues/178 I added some documentation on the behaviour of the PHP-FPM in the webserver.
Even though the behaviour is currently "expected" it is not obvious for the user.
Copy link
Contributor
@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but I am not sure everyone will get what the tip is trying to warn about from the current wording. Maybe we should add something like, "This means when an index.html file is present in ``public``, it will be displayed instead of your Symfony application."

@Eydamos Eydamos force-pushed the minor/add-documentation-about-php-fpm branch from 46e7e74 to 9b60a72 Compare April 2, 2020 11:26
@Eydamos Eydamos force-pushed the minor/add-documentation-about-php-fpm branch from 9b60a72 to c7419b2 Compare April 2, 2020 11:26
@Eydamos
Copy link
Contributor Author
Eydamos commented Apr 2, 2020

@dbrumann I have improved the message of the tip to make the behaviour clearer
Please recheck

----------------

When the server starts it will check the ``public`` folder for an ``index.php``
file. If this file is found the server will automatically start with PHP-FPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot can you please check the first sentence? From your comment in the referenced issue, I get the feeling that more front-controller files are checked than just public/index.php?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it checks for "common" patterns like web/app.php, web/app_dev.php or public/index.php.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the text to mention those common patterns

----------------

When the server starts it will check the ``public`` folder for an ``index.php``
file. If this file is found the server will automatically start with PHP-FPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it checks for "common" patterns like web/app.php, web/app_dev.php or public/index.php.

@fabpot fabpot merged commit 32af5a3 into symfony:3.4 Apr 3, 2020
@Eydamos Eydamos deleted the minor/add-documentation-about-php-fpm branch April 3, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0