8000 add XML and PHP config examples by xabbuh · Pull Request #13277 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

add XML and PHP config examples #13277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2020
Merged

add XML and PHP config examples #13277

merged 1 commit into from
Feb 29, 2020

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Feb 28, 2020

fixes #13010

@xabbuh xabbuh added this to the 4.4 milestone Feb 28, 2020
@xabbuh xabbuh mentioned this pull request Feb 28, 2020
Merged
@xabbuh xabbuh force-pushed the issue-13010 branch 2 times, most recently from aeee1f4 to 9973e87 Compare February 28, 2020 13:07
@xabbuh xabbuh marked this pull request as ready for review February 28, 2020 13:08
@xabbuh xabbuh mentioned this pull request Feb 28, 2020
Closed
javiereguiluz
javiereguiluz reviewed Feb 28, 2020
View reviewed changes
messenger.rst Outdated

.. code-block:: xml

<!-- config/packages/messenger.xml -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be config/packages/test/messenger.xml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely, thanks for the heads up 👍

messenger.rst Outdated

.. code-block:: php

// config/packages/messenger.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this path.

fabpot added a commit to symfony/symfony that referenced this pull request Feb 29, 2020
@fabpot
bug #35897 [FrameworkBundle] add missing Messenger options to XML sch…
dc9a0b5 
…ema definition (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] add missing Messenger options to XML schema definition

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony/symfony-docs#13010
| License       | MIT
| Doc PR        | symfony/symfony-docs#13277

Commits
-------

45a033d add missing Messenger options to XML schema definition
@javiereguiluz
Copy link
Member

Thank you Christian.

@javiereguiluz javiereguiluz merged commit dcd7c39 into symfony:4.4 Feb 29, 2020
@xabbuh xabbuh deleted the issue-13010 branch February 29, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Messenger 4E66 Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @javiereguiluz @OskarStark @carsonbot
0