8000 cache doctor rst by smoench · Pull Request #13250 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

cache doctor rst #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2020
Merged

cache doctor rst #13250

merged 1 commit into from
Feb 27, 2020

Conversation

smoench
Copy link
Contributor
@smoench smoench commented Feb 25, 2020

This PR adapts the latest contribution OskarStark/doctor-rst#626

@smoench smoench requested a review from OskarStark February 25, 2020 14:10
@smoench smoench force-pushed the 34-cache-doctor-rst branch 2 times, most recently from e83f689 to fa2059e Compare February 25, 2020 14:14
@smoench smoench changed the title cache doctor rst WIP: cache doctor rst Feb 25, 2020
@smoench smoench force-pushed the 34-cache-doctor-rst branch 3 times, most recently from 76e871a to e95cba5 Compare February 25, 2020 14:44
@smoench
Copy link
Contributor Author
smoench commented Feb 25, 2020

Can actions/cache cache only directories and not a single file? Or what I'm doing wrong?

@smoench smoench force-pushed the 34-cache-doctor-rst branch 6 times, most recently from afe06a6 to f48ff98 Compare February 25, 2020 15:33
@smoench smoench changed the title WIP: cache doctor rst cache doctor rst Feb 25, 2020
@smoench
Copy link
Contributor Author
smoench commented Feb 25, 2020

I had to create .cache directory to get caching work

smoench
smoench commented Feb 25, 2020
View reviewed changes
@smoench smoench force-pushed the 34-cache-doctor-rst branch from f48ff98 to 34ac5ce Compare February 26, 2020 07:50
@smoench
Copy link
Contributor Author
smoench commented Feb 26, 2020 •
edited
Loading

Should I also provide PRs for 4.4, 5.0 and master?

@javiereguiluz
Copy link
Member

@smoench no, don't worry. We merge each PR in all active merges up to master. Thanks.

@smoench
Copy link
Contributor Author
smoench commented Feb 26, 2020

@javiereguiluz I was just asking as the suffix of cache key might has to change to base branch name

OskarStark
OskarStark reviewed Feb 26, 2020
View reviewed changes
@smoench smoench force-pushed the 34-cache-doctor-rst branch 4 times, most recently from 46c8790 to 16df0d2 Compare February 26, 2020 08:55
@smoench smoench force-pushed the 34-cache-doctor-rst branch 4 times, most recently from 956b0d3 to 6f0dfd1 Compare February 26, 2020 09:07
@smoench smoench requested a review from OskarStark February 26, 2020 09:19
OskarStark
OskarStark approved these changes Feb 26, 2020
8000 View reviewed changes
@smoench smoench force-pushed the 34-cache-doctor-rst branch 2 times, most recently from f64c784 to 595501b Compare February 27, 2020 10:49
@OskarStark
Copy link
Contributor

Wow
Screenshot 2020-02-27 12 05 56

@smoench
Copy link
Contributor Author
smoench commented Feb 27, 2020 •
edited
Loading

Please don't merge yet as the base branch resolving doesn't work

@smoench smoench force-pushed the 34-cache-doctor-rst branch from 595501b to 12f6ddc Compare February 27, 2020 12:09
@smoench
Copy link
Contributor Author
smoench commented Feb 27, 2020

Got it work. Ready for merge

OskarStark
OskarStark reviewed Feb 27, 2020
View reviewed changes
.github/workflows/ci.yaml
uses: actions/cache@v1
with:
path: .cache
key: ${{ runner.os }}-doctor-rst-${{ steps.extract_base_branch.outputs.branch }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick 👍

@OskarStark
Copy link
Contributor

Thank you Simon.

@OskarStark OskarStark merged commit 0bad48d into symfony:3.4 Feb 27, 2020
@smoench smoench deleted the 34-cache-doctor-rst branch February 27, 2020 12:20
@smoench
Copy link
Contributor Author
smoench commented Feb 27, 2020

From about ~10min to seconds 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smoench @javiereguiluz @OskarStark @carsonbot
0