8000 Update return statement for getUser by qdequippe · Pull Request #13248 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update return statement for getUser #13248

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2020
Merged

Update return statement for getUser #13248

merged 1 commit into from
Feb 26, 2020

Conversation

qdequippe
Copy link
Contributor
@qdequippe qdequippe commented Feb 25, 2020 •
edited
Loading

getUser function excepts null or UserInterface to be returned.

Maybe only for DX.

@qdequippe qdequippe requested a review from xabbuh February 25, 2020 13:46
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 26, 2020
@qdequippe @javiereguiluz
Update return statement for getUser …
3420684 
`getUser` function excepts null or UserInterface to be returned.
@javiereguiluz javiereguiluz changed the base branch from 4.4 to 3.4 February 26, 2020 07:58
@javiereguiluz
Copy link
Member

Good catch! Thanks Quentin and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 903824a into symfony:3.4 Feb 26, 2020
@qdequippe qdequippe deleted the patch-3 branch February 26, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@qdequippe @javiereguiluz @OskarStark @carsonbot
0