-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Form] added the "choice_filter" option #13223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
``choice_filter`` | ||
~~~~~~~~~~~~~~~~~ | ||
|
||
**type**: ``callable``, ``string`` or :class:`Symfony\\Component\\PropertyAccess\\PropertyPath` **default**: ``null`` | ||
|
||
.. versionadded:: 5.1 | ||
|
||
The ``choice_filter`` option has been introduced in Symfony 5.1. | ||
|
||
When using predefined choice types from Symfony core or vendor libraries (i.e. | ||
:doc:`CountryType </reference/forms/types/country>`) this option lets you | ||
define a callable that take each choice as only argument and must return | ||
``true`` to keep it or ``false`` to discard it:: | ||
|
||
// src/Form/Type/AddressType.php | ||
namespace App\Form\Type; | ||
|
||
use Symfony\Component\Form\AbstractType; | ||
use Symfony\Component\Form\Extension\Core\Type\CountryType; | ||
use Symfony\Component\Form\FormBuilderInterface; | ||
use Symfony\Component\OptionsResolver\OptionsResolver; | ||
|
||
class AddressType extends AbstractType | ||
{ | ||
public function configureOptions(OptionsResolver $resolver) | ||
{ | ||
$resolver | ||
->setDefaults([ | ||
// enable this type to accept a limited set of countries | ||
'allowed_countries' => null, | ||
]) | ||
; | ||
} | ||
|
||
public function buildForm(FormBuilderInterface $builder, array $options) | ||
{ | ||
$allowedCountries = $options['allowed_countries']; | ||
|
||
$builder | ||
// ... | ||
->add('country', CountryType::class, [ | ||
// if the AddressType "allowed_countries" option is passed, | ||
// use it to create a filter | ||
'choice_filter' => $allowedCountries ? function ($countryCode) use ($allowedCountries) { | ||
return in_array($countryCode, $allowedCountries, true); | ||
} : null, | ||
|
||
]) | ||
; | ||
} | ||
|
||
The option can be a callable or a property path when choices are objects:: | ||
|
||
// ... | ||
$builder | ||
->add('category', ChoiceType::class, [ | ||
// ... | ||
'choice_filter' => 'isSelectable', | ||
]) | ||
; | ||
|
||
.. tip:: | ||
|
||
Considering this ``AddressType`` could be an entry of a ``CollectionType`` | ||
you should use the :class:`Symfony\\Component\\Form\\ChoiceList\\ChoiceList` | ||
class helper to enable caching:: | ||
|
||
// src/Form/Type/AddressType.php | ||
// ... | ||
use Symfony\Component\Form\ChoiceList\ChoiceList; | ||
|
||
// ... | ||
'choice_filter' => $allowedCountries ? ChoiceList::filter( | ||
// pass the type as first argument | ||
$this, | ||
function ($countryCode) use ($allowedCountries) { | ||
return in_array($countryCode, $allowedCountries, true); | ||
}, | ||
// pass the option that makes the filter "vary" to compute a unique hash | ||
$allowedCountries | ||
) : null, | ||
// ... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.