[PropertyAccess] Non-standard adder/remover methods #13137
Conversation
|
Fyi: Marked as "waiting code merge" as I think it depends on symfony/symfony#38515 |
|
@wouterj I does not depends on that PR, it was dependant on symfony/symfony#30704 which I finished a long time ago ^^ |
|
Oh, I'm sorry. I thought that PR only did changes to PropertyInfo and missed the big changes to the PropertyAccessor. |
There was a problem hiding this comment.
Thank you @Korbeil! I've proposed some changes to slightly improve the code example.
Can you please also add a versionadded directive like:
.. versionadded:: 5.1
Support for non-standard adder/remover methods was introduced in Symfony 5.1.And at last, please rebase this PR on the 5.1 branch (using git rebase --onto origin/5.1 origin/master).
If you don't have time to work on these changes (or something is unclear), please tell me and I'll finish this PR.
62f43d9 to
b710816
Compare
b710816 to
bf6cca9
Compare
|
@wouterj I made all requested changes |
|
Hi @Korbeil. I was about to merge this PR but I'm lost in all the core commits and PRs again.. This PR has got the "4.4" milestone, which makes me think it should be merged in 4.4. But it appears like the feature is introduced in 5.1. Can you please confirm which version should be used? |
|
@wouterj, As you can see in related PR: symfony/symfony#30704 It was firstly tagged in Or maybe it's my github enhanced addon that shows it ? |
|
Oh, I don't have that feature. That seems extremely useful 😄
You probably submitted this PR when 4.4 was in development, causing a doc team member to flag it as |
|
Yay, and finally it is merged. Thanks for your patience & contributions @Korbeil! |
Will add documentation about non-standard adder/remover methods for PropertyAccessor.
Related to #13023 and symfony/symfony#9336
This is not a complete documentation for related issues, but this will introduce one of the possible new use.