8000 [Security] Remove mention of removed firewall ListenerInterface by HypeMC · Pull Request #13083 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Security] Remove mention of removed firewall ListenerInterface #13083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

[Security] Remove mention of removed firewall ListenerInterface #13083

merged 1 commit into from
Feb 10, 2020

Conversation

HypeMC
Copy link
Member
@HypeMC HypeMC commented Feb 8, 2020 •
edited by HeahDude
Loading

Fixes #13069.

The Symfony\Component\Security\Http\Firewall\ListenerInterface has been removed in Symfony 5, yet there are still some references to it in the docs. This PR removes any remaining references to the interface.

@HypeMC HypeMC changed the title Remove mention of removed firewall ListenerInterface [Security] Remove mention of removed firewall ListenerInterface Feb 8, 2020
@HeahDude HeahDude mentioned this pull request Feb 9, 2020
Closed
@HeahDude HeahDude added this to the 4.4 milestone Feb 9, 2020
javiereguiluz
javiereguiluz approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is correct! See https://github.com/symfony/symfony/blob/43688482bc01c40ec421ff9552e1455df460d3f3/src/Symfony/Component/Security/Http/Firewall/ListenerInterface.php#L21

Thanks @HypeMC !

@javiereguiluz javiereguiluz changed the base branch from 5.0 to 4.4 February 10, 2020 12:22
javiereguiluz added a commit that referenced this pull request Feb 10, 2020
@javiereguiluz
minor #13083 [Security] Remove mention of removed firewall ListenerIn…
4213bed 
…terface (HypeMC)

This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #13083).

Discussion
----------

[Security] Remove mention of removed firewall ListenerInterface

Fixes #13069.

The `Symfony\Component\Security\Http\Firewall\ListenerInterface` has been removed in Symfony 5, yet there are still some references to it in the docs. This PR removes any remaining references to the interface.

Commits
-------

4b57c37 Remove mention of removed firewall ListenerInterface
@javiereguiluz javiereguiluz merged commit 4b57c37 into symfony:4.4 Feb 10, 2020
@HypeMC HypeMC deleted the remove-mention-of-listenerinterface branch February 10, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @javiereguiluz @HeahDude @carsonbot
0