-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix dead anchor links #13018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dead anchor links #13018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
security/password_migration.rst
Outdated
@@ -127,16 +127,18 @@ Upgrade the Password | |||
Upon successful login, the Security system checks whether a better algorithm | |||
is available to hash the user's password. If it is, it'll hash the correct | |||
password using the new hash. If you use a Guard authenticator, you first need to | |||
`provide the original password to the Security system <Provide the Password when using Guard>`_. | |||
:ref:`provide the original password to the Security system <provide-the-password-when-using-guard>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we dont need to add all these anchors and only:
- `provide the original password to the Security system <Provide the Password when using Guard>`_.
+ :ref:`provide the original password to the Security system <Provide the Password when using Guard>`.
Can you please change the commits this way (same for the others) and push again? We can then check it on the SymfonyCloud environment which gets deployed automatically. Thanks 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OskarStark I tried to remove anchors. I already tried before but it doesn't work (no links at all) on my environment (with the repository Dockerfile). However I pushed the changes to allow you to try on symfony cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, unfortunately it does not work as expected.
Based on the article it should work this way 🤔
EDIT: Ah when using :ref:
you should use the exact section heading! 👍 I am gonna fix this while merging, thank you!
* 4.4: Update email.rst minor to fix syntax. symfony#13018 Fix dead anchor links
* 5.0: Update email.rst minor to fix syntax. #13018 Fix dead anchor links
No description provided.