8000 Fix dead anchor links by l-vo · Pull Request #13018 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Fix dead anchor links #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix dead anchor links #13018

merged 1 commit into from
Feb 11, 2020

Conversation

l-vo
Copy link
Contributor
@l-vo l-vo commented Jan 30, 2020

No description provided.

Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@HeahDude HeahDude added this to the 4.4 milestone Feb 4, 2020
@@ -127,16 +127,18 @@ Upgrade the Password
Upon successful login, the Security system checks whether a better algorithm
is available to hash the user's password. If it is, it'll hash the correct
password using the new hash. If you use a Guard authenticator, you first need to
`provide the original password to the Security system <Provide the Password when using Guard>`_.
:ref:`provide the original password to the Security system <provide-the-password-when-using-guard>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we dont need to add all these anchors and only:

- `provide the original password to the Security system <Provide the Password when using Guard>`_.
+ :ref:`provide the original password to the Security system <Provide the Password when using Guard>`.

Can you please change the commits this way (same for the others) and push again? We can then check it on the SymfonyCloud environment which gets deployed automatically. Thanks 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark I tried to remove anchors. I already tried before but it doesn't work (no links at all) on my environment (with the repository Dockerfile). However I pushed the changes to allow you to try on symfony cloud.

Copy link
Contributor
@OskarStark OskarStark Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, unfortunately it does not work as expected.
Based on the article it should work this way 🤔

EDIT: Ah when using :ref: you should use the exact section heading! 👍 I am gonna fix this while merging, thank you!

OskarStark added a commit that referenced this pull request Feb 11, 2020
This PR was squashed before being merged into the 4.4 branch (closes #13018).

Discussion
----------

Fix dead anchor links

Commits
-------

7dc490b Fix dead anchor links
OskarStark added a commit that referenced this pull request Feb 11, 2020
@OskarStark OskarStark merged commit 7dc490b into symfony:4.4 Feb 11, 2020
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Feb 11, 2020
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Feb 11, 2020
@l-vo l-vo deleted the 4.4 branch February 11, 2020 09:48
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Feb 12, 2020
* 4.4:
  Update email.rst
  minor to fix syntax. symfony#13018
  Fix dead anchor links
OskarStark added a commit that referenced this pull request Feb 12, 2020
* 5.0:
  Update email.rst
  minor to fix syntax. #13018
  Fix dead anchor links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0