Workflow: align Example for property access with implementation of Me… #12988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyrixx can you please have a look here? Thanks 🙏 |
lyrixx
approved these changes
Jan 27, 2020
lyrixx
reviewed
Jan 27, 2020
|
@lyrixx I'm going to merge this. I saw that the same change can be done in 3.4 branch. Is that correct ... or does this only work starting from another branch? Thanks! |
|
@javiereguiluz Thanks for seeking :) But nope. It's only for Symfony 4.3 (so 4.4) |
OskarStark
approved these changes
Jan 30, 2020
f295d08 to
5272a25
Compare
|
Thank you Simon and congrats on your first contribution to the Symfony documentation 🎉 |
OskarStark
added a commit
that referenced
this pull request
Jan 30, 2020
…ation of Me… (simon-schubert) This PR was submitted for the 4.4 branch but it was squashed and merged into the 4.3 branch instead (closes #12988). Discussion ---------- Workflow: align Example for property access with implementation of Me… The Implementation in Symfony\Component\Workflow\MarkingStore\MethodMarkingStore does not use symfony/property-access (as the former implementations like e.g. SingleStateMarkingStore did) and requires to have getter/setter implemented in your entity. Therefore the example in docs does not work (any longer). I don't know, why the usage of symfony/property-access was dropped, but it seemed to me not accidentally. That's why I decided to send a PR to update docs. But maybe the implementation is "wrong" and should be changed instead. So please check carefully. Thank you. Commits ------- 5272a25 Workflow: align Example for property access with implementation of Me…
|
thank you @OskarStark , @javiereguiluz and @lyrixx 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Implementation in Symfony\Component\Workflow\MarkingStore\MethodMarkingStore does not use symfony/property-access (as the former implementations like e.g. SingleStateMarkingStore did) and requires to have getter/setter implemented in your entity. Therefore the example in docs does not work (any longer). I don't know, why the usage of symfony/property-access was dropped, but it seemed to me not accidentally. That's why I decided to send a PR to update docs. But maybe the implementation is "wrong" and should be changed instead. So please check carefully. Thank you.