8000 Move method and class by OskarStark · Pull Request #12945 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Move method and class #12945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Move method and class #12945

merged 1 commit into from
Jan 16, 2020

Conversation

OskarStark
Copy link
Contributor

It reads more natural to me.

I would check the following branches if you agree and in this case we could add a Doctor rule.

Cheers

@OskarStark
Move method and class
8bffa06 
It reads more natural to me
@OskarStark OskarStark requested a review from xabbuh as a code owner January 16, 2020 05:01
@OskarStark OskarStark requested a review from HeahDude January 16, 2020 05:16
javiereguiluz
javiereguiluz approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better. I hope there are not many changes like these to do in the docs or it will be tedious to fix everything.

Thanks Oskar!

@OskarStark OskarStark mentioned this pull request Jan 16, 2020
Open
OskarStark added a commit that referenced this pull request Jan 16, 2020
@OskarStark
minor #12945 Move method and class (OskarStark)
0c91dfc 
This PR was merged into the 3.4 branch.

Discussion
----------

Move method and class

It reads more natural to me.

I would check the following branches if you agree and in this case we could add a Doctor rule.

Cheers

Commits
-------

8bffa06 Move method and class
@OskarStark OskarStark merged commit 8bffa06 into symfony:3.4 Jan 16, 2020
@OskarStark OskarStark deleted the method-3.4 branch January 16, 2020 08:09
@xabbuh
Copy link
Member
xabbuh commented Jan 16, 2020

👍 from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @xabbuh @javiereguiluz @carsonbot
0