8000 Use a instead of an before consonant sounds by greg0ire · Pull Request #12799 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Use a instead of an before consonant sounds #12799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Dec 11, 2019
Merged

Use a instead of an before consonant sounds #12799

javiereguiluz merged 1 commit into from
Dec 11, 2019

Conversation

@greg0ire
Copy link
Contributor
@greg0ire greg0ire commented Dec 10, 2019 •
edited
Loading

u is a vowel, but will sometime produce a consonant sound, as in user
([ˈjuːzər]) or URL ([ˌjuːɑːrˈɛl]).
See https://www.grammar.com/a-vs-an-when-to-use/

@greg0ire greg0ire changed the title Use a instead of an befor consonant sounds Use a instead of an before consonant sounds Dec 10, 2019
@OskarStark
Copy link
Contributor
OskarStark commented Dec 11, 2019 •
edited
Loading

Could you please target 🎯 4.3 branch here? We can check 3.4 manually afterwards because mercure isn’t available in 3.4 AFAIK

@greg0ire
Use a instead of an before consonant sounds
9fdac8b 
u is a vowel, but will sometime produce a consonant sound, as in user
([ˈjuːzər]) or URL ([ˌjuːɑːrˈɛl]).
See https://www.grammar.com/a-vs-an-when-to-use/
@greg0ire greg0ire changed the base branch from master to 4.3 December 11, 2019 09:07
@greg0ire
Copy link
Contributor Author
greg0ire commented Dec 11, 2019

@OskarStark done :)

@OskarStark OskarStark added this to the 4.3 milestone Dec 11, 2019
@javiereguiluz
Copy link
Member
javiereguiluz commented Dec 11, 2019

Very nice contribution! Thanks Grégoire!

javiereguiluz added a commit that referenced this pull request Dec 11, 2019
@javiereguiluz
minor #12799 Use a instead of an before consonant sounds (greg0ire)
97a33ae 
This PR was merged into the 4.3 branch.

Discussion
----------

Use a instead of an before consonant sounds

u is a vowel, but will sometime produce a consonant sound, as in user
(`[ˈjuːzər]`) or URL (`[ˌjuːɑːrˈɛl]`).
See https://www.grammar.com/a-vs-an-when-to-use/

Commits
-------

9fdac8b Use a instead of an before consonant sounds
@javiereguiluz javiereguiluz merged commit 9fdac8b into symfony:4.3 Dec 11, 2019
@greg0ire greg0ire deleted the a-url branch December 11, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@greg0ire @OskarStark @javiereguiluz @carsonbot
0