It's needed to change the returned string in testControllerResponse #12798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@demyanovs thanks for this contribution. I haven't run the code shown on this page ... but the whole test code looks correct to me because of this:
Do you have the exact same code as in this test and the result is different? Thanks. |
|
@javiereguiluz thanks for the response. |
|
That looks indeed like a bug, thank you both for sharing the very helpful screenshots 👍🏻🙂 |
|
My mistake was that I was looking at 3.4 branch ... and this apparently changed in 4.3. So, we're merging it in 4.3 (and 4.4., 5.0 and master). Thanks @demyanovs. |
Following the documentation, we check the Calendar application and get the string "Yep, this is a leap year!" instead of "Hello Fabien".
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2020
…lerResponse (demyanovs) This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12798). Discussion ---------- It's needed to change the returned string in testControllerResponse Following the documentation, we check the Calendar application and get the string "Yep, this is a leap year!" instead of "Hello Fabien". <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 8f96598 It's needed to change the returned string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the documentation, we check the Calendar application and get the string "Yep, this is a leap year!" instead of "Hello Fabien".