8000 [Messenger] update events for 4.4 by Tobion · Pull Request #12586 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] update events for 4.4 #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2019
Merged

[Messenger] update events for 4.4 #12586

merged 1 commit into from
Nov 9, 2019

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Nov 3, 2019

Documentation for symfony/symfony#34217

@Tobion Tobion mentioned this pull request Nov 3, 2019
Merged
@javiereguiluz javiereguiluz added this to the 4.4 milestone Nov 4, 2019
dbrumann
dbrumann approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor
@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick, but I would prefer if these where ordered alphabetically.

@Tobion
Copy link
Contributor Author
Tobion commented Nov 4, 2019

I think listing them by the order they are dispatched is more readable and logical.

@Tobion Tobion mentioned this pull request Nov 5, 2019
Closed
@wouterj
Copy link
Member
wouterj commented Nov 9, 2019

Thanks! I agree with ordering them in the order they are dispatched.

wouterj added a commit that referenced this pull request Nov 9, 2019
@wouterj
feature #12586 [Messenger] update events for 4.4 (Tobion)
3ef26b4 
This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] update events for 4.4

Documentation for symfony/symfony#34217

Commits
-------

3374261 [Messenger] update events for 4.4
@wouterj wouterj merged commit 3374261 into symfony:4.4 Nov 9, 2019
@Tobion Tobion deleted the patch-3 branch November 9, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Tobion @wouterj @javiereguiluz @OskarStark @dbrumann @carsonbot
0