Showing new -extra Twig extension repos #12505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Oct 18, 2019
|
Perfectly explained! Thanks Ryan. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 18, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Showing new -extra Twig extension repos Recently, the old Twig extension repositories were deprecated and new (and mostly identical) `-extra` repos were added. So, mostly people just need to use the new library name. However, to get the new extensions to be loaded automatically, the user must also have the new `twig/extra-bundle` installed (this detects the `-extra` libraries and registers the extensions). Knowing this, the diff is self-explanatory. However, the workflow for *new* users will be simpler. Starting yesterday, when you run `composer require twig`, you get a `twig-pack` which contains TwigBundle AND `twig/extra-bundle`. That means that new users will *only* need to `composer require twig/cssinliner-extra`, they will not also need to install `twig/extra-bundle`. But, to be safe, I've added it here so that it works for everyone. Maybe someday we'll remove that part. Also, For Inky, when the repository was moved, the filter was also changed from `inky` to `inky_to_html`: https://twig.symfony.com/doc/2.x/filters/inky_to_html.html Finally, all of this requires Twig 2.12. I did not mention that. We *could*, but if you try to install `twig/extra-bundle` on a lower version, you'll get a composer error about the version problem. Now that my PR description is longer than my patch... I'll stop ;) Commits ------- 6db1feb Showing new -extra Twig extension repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the old Twig extension repositories were deprecated and new (and mostly identical)
-extrarepos were added. So, mostly people just need to use the new library name. However, to get the new extensions to be loaded automatically, the user must also have the newtwig/extra-bundleinstalled (this detects the-extralibraries and registers the extensions).Knowing this, the diff is self-explanatory. However, the workflow for new users will be simpler. Starting yesterday, when you run
composer require twig, you get atwig-packwhich contains TwigBundle ANDtwig/extra-bundle. That means that new users will only need tocomposer require twig/cssinliner-extra, they will not also need to installtwig/extra-bundle. But, to be safe, I've added it here so that it works for everyone. Maybe someday we'll remove that part.Also, For Inky, when the repository was moved, the filter was also changed from
inkytoinky_to_html: https://twig.symfony.com/doc/2.x/filters/inky_to_html.htmlFinally, all of this requires Twig 2.12. I did not mention that. We could, but if you try to install
twig/extra-bundleon a lower version, you'll get a composer error about the version problem.Now that my PR description is longer than my patch... I'll stop ;)