8000 Added namespace for example controller by TheGarious · Pull Request #12501 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Added namespace for example controller #12501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Added namespace for example controller #12501

merged 1 commit into from
Oct 18, 2019

Conversation

TheGarious
Copy link
Contributor

I have a question.

Do i need added "<?php" for each example function in php in this docs ?

If yes, i create a new PR with all example with added <?php for each php example.

Thanks

OskarStark
OskarStark reviewed Oct 18, 2019
View reviewed changes
@javiereguiluz
Copy link
Member

Thanks Gary.

javiereguiluz added a commit that referenced this pull request Oct 18, 2019
@javiereguiluz
minor #12501 Added namespace for example controller (TheGarious)
1cc4df1 
This PR was squashed before being merged into the 4.3 branch (closes #12501).

Discussion
----------

Added namespace for example controller

I have a question.

Do i need added "<?php" for each example function in php in this docs ?

If yes, i create a new PR with all example with added <?php for each php example.

Thanks

Commits
-------

1f88d28 Added namespace for example controller
@javiereguiluz javiereguiluz merged commit 1f88d28 into symfony:4.3 Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheGarious @javiereguiluz @OskarStark @carsonbot
0