8000 Fix invalid reference to importing JavaScript by artmatsak · Pull Request #12412 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix invalid reference to importing JavaScript #12 8000 412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix invalid reference to importing JavaScript #12412

merged 1 commit into from
Oct 3, 2019

Conversation

artmatsak
Copy link
Contributor

The code block imports CSS but the comment above it talks about importing "some JavaScript".

@javiereguiluz
Copy link
Member

Good catch! Thanks for fixing it ... and congrats on your first Symfony Docs contribution.

javiereguiluz added a commit that referenced this pull request Oct 3, 2019
@javiereguiluz
minor #12412 Fix invalid reference to importing JavaScript (artmatsak)
e61ccc6 
This PR was merged into the 4.3 branch.

Discussion
----------

Fix invalid reference to importing JavaScript

The code block imports CSS but the comment above it talks about importing "some JavaScript".

Commits
-------

cd84f1b Fix invalid reference to importing JavaScript
@javiereguiluz javiereguiluz merged commit cd84f1b into symfony:4.3 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
front-end Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artmatsak 34D5 @javiereguiluz @carsonbot
0