8000 Update doctrine.rst by hectorprats · Pull Request #12393 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update doctrine.rst #12393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update doctrine.rst #12393

wants to merge 1 commit into from

Conversation

hectorprats
Copy link
Contributor

Uploading code of directly access in controller of the custom dbal connections.

@hectorprats
Copy link
Contributor Author
hectorprats commented 8000 Sep 30, 2019

I don't know what is wrong with that

gregurco
gregurco reviewed Oct 4, 2019
View reviewed changes
OskarStark
OskarStark reviewed Oct 4, 2019
View reviewed changes
OskarStark
OskarStark reviewed Oct 4, 2019
View reviewed changes
OskarStark
OskarStark reviewed Oct 4, 2019
View reviewed changes
OskarStark
OskarStark reviewed Oct 4, 2019
View reviewed changes
OskarStark
OskarStark reviewed Oct 4, 2019
View reviewed changes
@hectorprats
Copy link
Contributor Author

thank you @OskarStark . You have been a great help

OskarStark
OskarStark reviewed Oct 10, 2019
View reviewed changes
@OskarStark
Copy link
Contributor

@javiereguiluz please give us a final review here. Thanks

wouterj added a commit that referenced this pull request Nov 23, 2019
@wouterj
[#12393] Rewrote the sentence a bit
93ef5f2
wouterj added a commit that referenced this pull request Nov 23, 2019
@wouterj
Merge branch '4.3' into 4.4
cf407e1 
* 4.3:
  [#12393] Rewrote the sentence a bit
  Update doctrine.rst
wouterj added a commit that referenced this pull request Nov 23, 2019
@wouterj
Merge branch '4.4' into 5.0
d4419b2 
* 4.4:
  [#12393] Rewrote the sentence a bit
  Update doctrine.rst
@wouterj wouterj closed this in 65c4dfd Nov 23, 2019
@wouterj
Copy link
Member
wouterj commented Nov 23, 2019

Thanks for adding this tip to the docs @hectorprats! I've merged this and rewrote the sentence a bit in 93ef5f2 to make clear that you have to extend AbstractController for this to work (that's not a requirement anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregurco gregurco gregurco left review comments

@OskarStark OskarStark OskarStark approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hectorprats @OskarStark @wouterj @gregurco @carsonbot
0