10000 Explain Symfony packs by javiereguiluz · Pull Request #12354 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Explain Symfony packs #12354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2019
Merged

Explain Symfony packs #12354

merged 1 commit into from
Sep 24, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #12130.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Sep 23, 2019
@javiereguiluz javiereguiluz mentioned this pull request Sep 23, 2019
Closed
OskarStark
OskarStark reviewed Sep 23, 2019
View reviewed changes
javiereguiluz added a commit that referenced this pull request Sep 24, 2019
@javiereguiluz
minor #12354 Explain Symfony packs (javiereguiluz)
b676148 
This PR was squashed before being merged into the 4.3 branch (closes #12354).

Discussion
----------

Explain Symfony packs

Fixes #12130.

Commits
-------

9d07ac3 Explain Symfony packs
@javiereguiluz javiereguiluz merged commit 9d07ac3 into symfony:4.3 Sep 24, 2019
@javiereguiluz javiereguiluz deleted the fix_12130 branch September 24, 2019 09:19
xabbuh
xabbuh reviewed Sep 25, 2019
View reviewed changes
setup.rst

By default, when installing Symfony packs, your ``composer.json`` file shows the
pack dependency (e.g. ``"symfony/debug-pack": "^1.0"``) instead of the actual
packages installed. To show the packages, add the ``--unpack`` option when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make sense to have a new command provided by Flex which actually just displays these packages instead of really unpacking the pack (and thus modifying the composer.json file).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add it to the RFC symfony/flex#518

Copy link
Member

Choose a reason for hiding this comment

8000 The reason will be displayed to describe this comment to others. Learn more.

great idea @maxhelias

@xabbuh xabbuh mentioned this pull request Sep 25, 2019
Closed
stof
stof reviewed Sep 25, 2019
View reviewed changes
setup.rst

By default, when installing Symfony packs, your ``composer.json`` file shows the
pack dependency (e.g. ``"symfony/debug-pack": "^1.0"``) instead of the actual
packages installed. To show the packages, add the ``--unpack`` option when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say you composer.json depends on the pack rather than shows the pack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@OskarStark OskarStark OskarStark left review comments

@xabbuh xabbuh xabbuh left review comments

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@javiereguiluz @stof @OskarStark @xabbuh @maxhelias @carsonbot
0