Move stopwatch docs #12291
Move stopwatch docs #12291
Conversation
| @@ -445,4 +445,5 @@ | |||
| /console/request_context /routing | |||
| /form/action_method /forms | |||
| /reference/requirements /setup | |||
| /bundles/inheritance /bundles/override | |||
| /bundles/inheritance /bundles/override | |||
| /components/stopwatch https://symfony.com/components/Stopwatch | |||
There was a problem hiding this comment.
why. do we need https://symfony.com/ as this is the default?
There was a problem hiding this comment.
Because this redirection map is:
OLD documentation page path -> NEW documentation page path
If we use /components/Stopwatch it will redirect to https://symfony.com/doc/current/components/Stopwatch.html.
We need to redirect to an entirely different URL and that's why we need absolute URLs.
|
@javiereguiluz Can you rebase here? |
|
I'm not going to rebase yet ... because we're waiting for the "green light" to this proposal ... so this could be discarded at the end. Let's wait a bit. Thanks. |
|
I am 👎🏻 against moving the docs |
|
Hi @javiereguiluz! I somehow completely missed this PR. I think the changes in this PR are great, they do not add a new guide but instead document the component where it's most useful. I've rebased this PR on 4.4 in #14333 . |
…aviereguiluz) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Stopwatch] Move component docs into framework guides This PR continues the great work done by @javiereguiluz in #12291 . It's mostly a rebase to 4.4. Commits ------- fc847c4 [Stopwatch] Move component docs into framework guides
No description provided.