8000 Fixed namespace in example by raitocz · Pull Request #12191 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fixed namespace in example #12191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2019
Merged

Fixed namespace in example #12191

merged 1 commit into from
Aug 17, 2019

Conversation

raitocz
Copy link
Contributor
@raitocz raitocz commented Aug 17, 2019

PSR-4 I guess... it is also later referenced in next example

@raitocz
Fixed namespace in example
15fdde4 
PSR-4 I guess... it is also later referenced in next example
@raitocz raitocz requested a review from xabbuh as a code owner August 17, 2019 08:57
@xabbuh xabbuh added this to the 4.3 milestone Aug 17, 2019
wouterj added a commit that referenced this pull request Aug 17, 2019
@wouterj
bug #12191 Fixed namespace in example (raitocz)
22ee54a 
This PR was merged into the 4.3 branch.

Discussion
----------

Fixed namespace in example

PSR-4 I guess... it is also later referenced in next example

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

15fdde4 Fixed namespace in example
wouterj added a commit that referenced this pull request Aug 17, 2019
@wouterj
[#12191] Fixed another wrong namespace
c04ea2c
@wouterj wouterj merged commit 15fdde4 into symfony:4.3 Aug 17, 2019
@wouterj
Copy link
Member
wouterj commented Aug 17, 2019

Thank you for catching this error @raitocz! I found another occurence of this error later in the article, which I fixed with c04ea2c.

OskarStark added a commit that referenced this pull request Aug 20, 2019
@OskarStark
Merge branch '4.3' into 4.4
2584959 
* 4.3:
  Tweaks #11274
  initial DOCtor-RST setup.
  [#12191] Fixed another wrong namespace
  Fixed namespace in example
  fix a little code example issue
  Remove unused link
  Adding missing semi colons
  Fix Description of PHPUnitBridge
  Fix variable name
OskarStark added a commit that referenced this pull request Aug 20, 2019
@OskarStark
Merge branch '4.4'
6eb7bf2 
* 4.4:
  Tweaks #11274
  initial DOCtor-RST setup.
  [#12191] Fixed another wrong namespace
  Fixed namespace in example
  fix a little code example issue
  Remove unused link
  Adding missing semi colons
  Fix Description of PHPUnitBridge
  Fix variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@raitocz @wouterj @OskarStark @xabbuh @maxhelias @carsonbot
0