8000 Fix rules according to the current release process by funivan · Pull Request #12047 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix rules according to the current release process #12047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix rules according to the current release process #12047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix rules according to the current release process 
I read rules and think that I can extend non-internal classes and not test classes. 
Only security fixes can cause BC.
But this PR symfony/symfony#20487 is not Security fix and break my code. 

I extended `ProgressBar` and didn't see any troubles. All works fine. After upgrade from 3.2 to 3.3 I got BC. 
To avoid future troubles it is better to not extend classes. Developers should know that not only security fixes can break the code.
  • Loading branch information
@funivan
funivan authored Jul 29, 2019
commit cf8fd76720f3bf036762e65125296c2c8f58e262
2 changes: 1 addition & 1 deletion contributing/code/bc.rst
View file
Open in desktop
5EB4
Original file line number Diff line numberDiff line change
Expand Up @@ -110,7 +110,7 @@ covered by our backward compatibility promise:
+-----------------------------------------------+-----------------------------+
| Create a new instance | Yes |
+-----------------------------------------------+-----------------------------+
| Extend the class | Yes |
| Extend the class | No |
+-----------------------------------------------+-----------------------------+
| Access a public property | Yes |
+-----------------------------------------------+-----------------------------+
Expand Down
0