Add attachment with url #11965
Add attachment with url #11965
Conversation
Without this we may think (as I did until I tested) that it can only work with a file path and not with url
|
Nice addition Laurent! I didn't know this, so thanks for contributing it and thanks for teaching me about this! |
This PR was merged into the 4.3 branch. Discussion ---------- Add attachment with url Without this we may think (as I did until I tested) that it can only work with a file path and not with url <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 165e128 Add attachment with url
|
I am not sure that we should really document this behaviour. That relies on how PHP is configured to work with URLs when |
|
I think it’s nice to know but a warning or a comment about xabbuh‘s comment would be useful |
|
Yes, I''m going to add a brief comment about this ... meanwhile, I created the #11995 issue to not forget about this. |
|
I don't know if we can implement it to work without having to rely on php settings, but I think it's needed, because sometimes we don't know where the file is physically stored on the server, especially if we use a Route, as in the case I've tested it. |
|
This should be reverted as it was never meant to be supported. |
|
As you wish, but as explained above I think it's needed, especially when using Routes |
|
reverted in #14186 |
Without this we may think (as I did until I tested) that it can only work with a file path and not with url