[Form] Documented the intl option in TimezoneType #11867
Conversation
|
@ro0NL if you have some time, please review this. Thanks! |
| @@ -105,6 +129,8 @@ Inherited Options | |||
|
|
|||
| These options inherit from the :doc:`ChoiceType </reference/forms/types/choice>`: | |||
|
|
|||
| .. include:: /reference/forms/types/options/choice_translation_domain.rst.inc | |||
There was a problem hiding this comment.
I think we should add a note that this option can only be used when intl is set to true.
There was a problem hiding this comment.
I thought about that ... however, I saw that the code shows a perfect error message when you do that (see https://github.com/symfony/symfony/pull/31294/files#diff-c6198934d4f35bc102ff362d40b71285R72) so I guess it's fine to not add these implementation details in the docs.
There was a problem hiding this comment.
It's also more or less explained above. Works for me :)
There was a problem hiding this comment.
My thought is that people will just notice this option and try to use it. But it's not a big deal. We can add something later anyway if we receive complaints about it not being straight-forward (the error provided by the form type is quite clear indeed).
| @@ -105,6 +129,8 @@ Inherited Options | |||
|
|
|||
| These options inherit from the :doc:`ChoiceType </reference/forms/types/choice>`: | |||
|
|
|||
| .. include:: /reference/forms/types/options/choice_translation_domain.rst.inc | |||
There was a problem hiding this comment.
It's also more or less explained above. Works for me :)
This fixes #11503.