8000 Reorder methods to be close to the given example by OskarStark · Pull Request #11554 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Reorder methods to be close to the given example #11554

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reorder methods to be close to the given example #11554

wants to merge 2 commits into from

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 3.4 milestone May 9, 2019
@OskarStark OskarStark changed the title Reorder and update example reorder methods to be close to the given example May 9, 2019
@OskarStark OskarStark changed the title reorder methods to be close to the given example Reorder methods to be close to the given example May 9, 2019
@javiereguiluz
Copy link
Member

I'd prefer to not sort methods differently. They are now sorted alphabetically, which is what we usually do in the docs. The other change look good to me.

@OskarStark
Copy link
Contributor Author

Ok, shall I then move the code between the methods and keep the order?
I mean the example shows the usage of the method 🤔

@javiereguiluz
Copy link
Member

I wouldn't change it either: code samples and descriptions are usually related, but not intimately related. Generally speaking, it should be OK to show options sorted alphabetically and then do whatever you want in the code example. Or maybe I'm missing something else here.

@OskarStark
Copy link
Contributor Author

Ok, I will provide a PR just for the trait 👍

@OskarStark OskarStark closed this May 14, 2019
@OskarStark OskarStark deleted the reorder-and-update-example branch May 14, 2019 11:09
@OskarStark OskarStark mentioned this pull request May 14, 2019
Merged
javiereguiluz added a commit that referenced this pull request May 15, 2019
@javiereguiluz
minor #11575 Import use statement for used trait (OskarStark)
aab5280 
This PR was merged into the 3.4 branch.

Discussion
----------

Import use statement for used trait

Refs #11554

Commits
-------

26b31ac Import use statement for used trait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work VarDumper
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @javiereguiluz @carsonbot
0