8000 [Session] Fix local variable in session example by Einenlum · Pull Request #11539 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Session] Fix local variable in session example #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2019
Merged

[Session] Fix local variable in session example #11539

merged 1 commit into from
May 7, 2019

Conversation

Einenlum
Copy link
Contributor
@Einenlum Einenlum commented May 7, 2019 •
edited
Loading

Fixes this code example: https://symfony.com/doc/current/session.html#basic-usage
($session -> $this->session)

@javiereguiluz javiereguiluz added this to the 4.2 milestone May 7, 2019
@javiereguiluz
Copy link
Member

Thanks Yann.

@javiereguiluz javiereguiluz merged commit 95fd311 into symfony:4.2 May 7, 2019
javiereguiluz added a commit that referenced this pull request May 7, 2019
@javiereguiluz
minor #11539 [Session] Fix local variable in session example (Einenlum)
65324f3 
This PR was merged into the 4.2 branch.

Discussion
----------

[Session] Fix local variable in session example

Fixes this code example: https://symfony.com/doc/current/session.html#basic-usage
(`$session` -> `$this->session`)

Commits
-------

95fd311 Fix local variable in session example
@Einenlum Einenlum deleted the 4.2 branch May 7, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Einenlum @javiereguiluz @carsonbot
0