fix indention #11508
Merged
fix indention #11508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1498080 to
2da8031
Compare
OskarStark
commented
May 2, 2019
| @@ -93,23 +93,23 @@ The ``match()`` method takes a request path and returns an array of attributes | |||
| (notice that the matched route is automatically stored under the special | |||
| ``_route`` attribute):: | |||
|
|
|||
| print_r($matcher->match('/bye')); | |||
| /* Gives: | |||
| $matcher->match('/bye'); | |||
There was a problem hiding this comment.
I think the print_r is not needed here
OskarStark
commented
May 2, 2019
| Explains the steps to follow to contribute fixes and new contents. It's the | ||
| same contribution process followed by most open source projects, so you may | ||
| already know everything that is needed. | ||
| Explains the steps to follow to contribute fixes and new contents. It's the |
There was a problem hiding this comment.
The result is the same and we should use 4 spaces for indention whenever we can
|
Nice work here! Thank you Oskar. |
javiereguiluz
added a commit
that referenced
this pull request
May 3, 2019
This PR was merged into the 3.4 branch. Discussion ---------- fix indention <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- cbe6e45 fix indention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.