8000 [Cache] Update cache for 4.2 by Nyholm · Pull Request #11391 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Update cache for 4.2 #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[Cache] Update cache for 4.2 #11391

wants to merge 7 commits into from

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Apr 9, 2019

This will continue the work started in #10685

We need to document the CacheInterface from Contracts better.

@Nyholm Nyholm marked this pull request as ready for review April 10, 2019 05:32
javiereguiluz
javiereguiluz reviewed Apr 10, 2019
View reviewed changes
@wouterj wouterj added this to the 4.2 milestone Apr 10, 2019
@wouterj wouterj mentioned this pull request 8000 Apr 10, 2019
Closed
wouterj
wouterj requested changes Apr 10, 2019
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again!

OskarStark
OskarStark reviewed Apr 10, 2019
View reviewed changes
Nyholm
Nyholm commented Apr 10, 2019
View reviewed changes
@Nyholm
Copy link
Member Author
Nyholm commented Apr 10, 2019

Thank you for the reviews. I've updated the PR

@javiereguiluz
Copy link
Member

Tobias, thanks for taking care of finishing this doc. We've merged it in 4.2 and master.

@Nyholm
Copy link
Member Author
Nyholm commented Apr 11, 2019

Woho, Thank you =)

@Nyholm Nyholm deleted the grekas-cache branch April 11, 2019 07:01
@Nyholm Nyholm mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@OskarStark OskarStark OskarStark left review comments

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Nyholm @javiereguiluz @wouterj @OskarStark @carsonbot @nicolas-grekas
0