8000 Swap aliases by greg0ire · Pull Request #11389 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Swap aliases #11389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

Swap aliases #11389

merged 1 commit into from
Apr 10, 2019

Conversation

greg0ire
Copy link
Contributor
@greg0ire greg0ire commented Apr 9, 2019

The comments above did not match. For the sake of explaining, it is
better to put the named aliases first.

@greg0ire
Swap aliases
5052a37 
The comments above did not match. For the sake of explaining, it is
better to put the named aliases first.
@greg0ire greg0ire changed the base branch from master to 4.2 April 9, 2019 19:55
@greg0ire greg0ire mentioned this pull request Apr 9, 2019
Merged
@wouterj
Copy link
Member
wouterj commented Apr 10, 2019 •
edited
Loading

Thanks for your quick fixes! I assume the order doesn't matter in real life projects? (maybe that's usefull to add, but I'm not sure)

@wouterj wouterj merged commit 5052a37 into symfony:4.2 Apr 10, 2019
wouterj added a commit that referenced this pull request Apr 10, 2019
@wouterj
minor #11389 Swap aliases (greg0ire)
5e1360b 
This PR was merged into the 4.2 branch.

Discussion
----------

Swap aliases

The comments above did not match. For the sake of explaining, it is
better to put the named aliases first.

Commits
-------

5052a37 Swap aliases
@greg0ire greg0ire deleted the swap-comments branch April 10, 2019 12:36
@greg0ire
Copy link
Contributor Author

Thanks for your quick fixes!

No problem, sorry for committing this in the first place!

I assume the order doesn't matter in real life projects? (maybe that's usefull to add, but I'm not sure)

I don't think it is but I don't know for sure, maybe @nicolas-grekas or @tgalopin can confirm.

@nicolas-grekas
Copy link
Member

corretc: the order doesn't matter

@greg0ire
Copy link
Contributor Author

That means I'm done! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@greg0ire @wouterj @nicolas-grekas @javiereguiluz @OskarStark @maxhelias @carsonbot
0