8000 [Cache] Show how to configure redis provider by Nyholm · Pull Request #11364 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Show how to configure redis provider #11364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[Cache] Show how to configure redis provider #11364

wants to merge 5 commits into from

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Apr 8, 2019 •
edited
Loading

This will properly fix #10989
Im not 100% confident on the xml configuration.

@nicolas-grekas is this a good description of the Provider?

@Nyholm Nyholm mentioned this pull request Apr 8, 2019
Closed
@Nyholm Nyholm changed the base branch from master to 3.4 April 8, 2019 16:59
nicolas-grekas
nicolas-grekas reviewed Apr 8, 2019
View reviewed changes
@Nyholm Nyholm changed the title Show how to configure redis provider [Cache] Show how to configure redis provider Apr 8, 2019
@javiereguiluz
Copy link
Member

@xabbuh could you please double check the XML config? Thanks!

wouterj
wouterj approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML looks good!

Looking at the XmlFileLoader, I it seems like key is used instead of name, but key defaults to name. So I think name looks more logical?

@javiereguiluz javiereguiluz added this to the 3.4 milestone Apr 9, 2019
@Nyholm
Copy link
Member Author
Nyholm commented Apr 9, 2019 •
edited
Loading

I did a quick search. Using "key" is standard on all other places in the docs

@Nyholm
Copy link
Member Author
Nyholm commented Apr 9, 2019

Thank you for the reviews!

javiereguiluz added a commit that referenced this pull request Apr 9, 2019
@javiereguiluz
minor #11364 [Cache] Show how to configure redis provider (Nyholm)
737539a 
This PR was squashed before being merged into the 3.4 branch (closes #11364).

Discussion
----------

[Cache] Show how to configure redis provider

This will properly fix #10989
Im not 100% confident on the xml configuration.

@nicolas-grekas is this a good description of the Provider?

Commits
-------

120a87e [Cache] Show how to configure redis provider
@javiereguiluz
Copy link
Member

Thanks Tobias (and reviewers) for another nice Cache contribution.

@Nyholm Nyholm deleted the issue-10989 branch April 9, 2019 14:31
@Nyholm Nyholm mentioned this pull request Apr 9, 2019
Merged
wouterj added a commit that referenced this pull request Apr 9, 2019
@wouterj
minor #11387 [Cache] Syntax fix (Nyholm)
1a33132 
This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] Syntax fix

I made a typo in #11364

Commits
-------

f21b15a [Cache] Syntax fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @javiereguiluz @nicolas-grekas @wouterj @carsonbot
0