8000 Fix resolve example by jderusse · Pull Request #11355 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Fix resolve example #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix resolve example #11355

merged 1 commit into from
Apr 8, 2019

Conversation

jderusse
Copy link
Member
@jderusse jderusse commented Apr 8, 2019

The resolve processor can only resolve parameters whereas the documentation give the feeling that we could resolve env variables too. Wich is not the case (see symfony/symfony#31000).

This PR change the example in order to be unambiguous.

@jderusse jderusse changed the base branch from master to 3.4 April 8, 2019 09:40
@OskarStark
Copy link
Contributor

Thank you Jérémy.

@OskarStark OskarStark merged commit 3e60b9d into symfony:3.4 Apr 8, 2019
OskarStark added a commit that referenced this pull request Apr 8, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Fix resolve example

The `resolve` processor can only resolve `parameters` whereas the documentation give the feeling that we could resolve env variables too. Wich is not the case (see symfony/symfony#31000).

This PR change the example in order to be unambiguous.

Commits
-------

3e60b9d Fix resolve example
@jderusse jderusse deleted the fix-resolve-example branch April 18, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0