8000 Add info about Preventing Escalations to Respectful Review Comments by llaakkkk · Pull Request #11347 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add info about Preventing Escalations to Respectful Review Comments #11347

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add info about Preventing Escalations to Respectful Review Comments #11347

wants to merge 1 commit into from

Conversation

llaakkkk
Copy link
@llaakkkk llaakkkk commented Apr 7, 2019

At FOSSHackathons the diversity group have discussed topics which we can cover in the documentation about Code Review Process.

@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 7, 2019
wouterj
wouterj approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor syntax comment, apart from that its perfect (do you want us to wait for feedback of other diversity members?)

greg0ire
greg0ire reviewed Apr 7, 2019
View reviewed changes
@greg0ire
Copy link
Contributor
greg0ire commented Apr 7, 2019

Please associate your email address with your Github account, or change the email in your commits to an address already associated with it, that way you will get credit for the commits :)

javiereguiluz
javiereguiluz approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llaakkkk very nice! Thanks for your contribution.

@llaakkkk
Copy link
Author
llaakkkk commented Apr 8, 2019

Just one minor syntax comment, apart from that its perfect (do you want us to wait for feedback of other diversity members?)

@wouterj no, the text is already approved by the diversity team

@llaakkkk
Copy link
Author
llaakkkk commented Apr 8, 2019 •
edited
Loading

Please associate your email address with your Github account, or change the email in your commits to an address already associated with it, that way you will get credit for the commits :)

@greg0ire fixed it, thanks)

@llaakkkk llaakkkk force-pushed the prevent_escalating_for_comments branch from 6a1be05 to fd3abc3 Compare April 8, 2019 09:57
@javiereguiluz javiereguiluz added this to the 3.4 milestone Apr 8, 2019
@javiereguiluz
Copy link
Member

Thank you @llaakkkk! We merged this in 3.4 brancha and we'll merge into the other branches automatically. GitHub shows this pull request closed instead of merged because of this branch change, but it's merged!

@greg0ire
Copy link
Contributor
greg0ire commented Apr 8, 2019 •
edited
Loading

@llaakkkk it does not look like it worked. The email you would have to add as a secondary address to your Github account is the lmc.eu one. When it works, that
octocat will become your user pic:

d7d68a77-bc82-47ae-b506-b9b807743544

@llaakkkk
Copy link
Author
llaakkkk commented Apr 8, 2019

@llaakkkk it does not look like it worked. The email you would have to add as a secondary address to your Github account is the lmc.eu one. When it works, that
octocat will become your user pic:

d7d68a77-bc82-47ae-b506-b9b807743544

@greg0ire I understood the reason, I am going to find how I can fix it. Because lmc.eu is my work email

@greg0ire
Copy link
Contributor
greg0ire commented Apr 8, 2019 •
edited
Loading

I think there will be no way for you to amend those commits so that you use the new address now that they have been merged, so the only way to fix this is to add your work email as a secondary address to your GH account. Personally, I did it, it's not an issue to me since I enabled 2FA.

@llaakkkk
Copy link
Author
llaakkkk commented Apr 9, 2019

I think there will be no way for you to amend those commits so that you use the new address now that they have been merged, so the only way to fix this is to add your work email as a secondary address to your GH account. Personally, I did it, it's not an issue to me since I enabled 2FA.

@greg0ire did it. Thank you for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@llaakkkk @greg0ire @javiereguiluz @wouterj @carsonbot
0